This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Update parser for payment requirement fields #26
Merged
+29
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `payment_required_by` and `price_guarantee_expires_at` are returned
from the API without microsecond precision:
"payment_requirements": {
"requires_instant_payment": false,
"price_guarantee_expires_at": "2021-12-24T11:39:45Z",
"payment_required_by": "2021-12-25T11:39:45Z"
},
jesse-c
approved these changes
Dec 22, 2021
sgerrand
deleted the
FLAPI-2064-fix-offer-payment-requirements-serialiser
branch
|
I corrected the examples in https://github.com/duffelhq/platform/pull/7762 |
|
Although we'll probably have to update everything else which flows on from that:
|
|
Ah yes, that PR was connected to this. Yes to at least those other 2 places. I can't think of anywhere else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 Both
payment_required_byandprice_guarantee_expires_atare returnedfrom the API without microsecond precision: